Skip to content

Fix depositories addresses not showing up#372

Merged
pedromcunha merged 1 commit into
mainfrom
fix/depositories-addresses
Jul 22, 2026
Merged

Fix depositories addresses not showing up#372
pedromcunha merged 1 commit into
mainfrom
fix/depositories-addresses

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

No description provided.

@pedromcunha
pedromcunha requested a review from ted-palmer July 22, 2026 01:42
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Claude finished @pedromcunha's task in 38s —— View job


Code Review: Fix depositories addresses not showing up

  • Read the diff and full snippet
  • Review for correctness and style

This correctly fixes the empty Chain column: the /chains API returns displayName (not name), so switching ${chain.name}${chain.displayName} on line 34 is the right fix. Moving VM_TYPE_LABELS into appendDepositories is harmless. Two things to clean up before merge:

🔴 Blocking — leftover debugger; statement

snippets/Depositories.mdx:48

const fetchChains = async () => {
  debugger;   // ← remove this

This is a debugging artifact. In production it will pause execution for any visitor who has browser devtools open, and it shouldn't ship in a docs snippet.

Fix this →

🟡 Minor — indentation

snippets/Depositories.mdx:20

The moved const VM_TYPE_LABELS = { line has 7 leading spaces instead of 6, so it's misaligned with the surrounding block. Cosmetic, but worth tidying while you're in here.

Note (pre-existing, not introduced by this PR)

The loader element on line 97 is given a className (loader-container-${id}), but lines 41 and 66 look it up via document.getElementById(...). getElementById matches on id, not class, so the loader-hiding logic never finds that element. Out of scope for this fix, but flagging since you're touching this file.

Overall the fix itself is correct — just drop the debugger; and this is good to go.

@mintlify

mintlify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jul 22, 2026, 1:43 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@pedromcunha
pedromcunha merged commit a77fd52 into main Jul 22, 2026
4 checks passed
@pedromcunha
pedromcunha deleted the fix/depositories-addresses branch July 22, 2026 01:44
@mintlify

mintlify Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟡 Building Jul 22, 2026, 1:42 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants